chore: add method to return cached config value#1944
Merged
Conversation
bumi
approved these changes
Nov 26, 2025
Contributor
bumi
left a comment
bumi
left a comment
There was a problem hiding this comment.
If that's the Go way of doing this 👍
config/config.go
Outdated
| return cfg.get(key, encryptionKey, cfg.db) | ||
| } | ||
|
|
||
| func (cfg *config) GetCached(key string, encryptionKey string) (string, error) { |
Contributor
There was a problem hiding this comment.
do we even need to methods for this?
can't/shouldn't this always be cached?
Contributor
Author
There was a problem hiding this comment.
True. So we delete the key from the cache when we set a new value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1943
Now with Postgres these config Gets are doing remote API calls and we need to be careful not to do too many of them.
(Just the general idea, we can apply to most of the config
Gets that never change over the app's lifetime if it sounds good)TODO: